Skip to content

[docker-in-docker] - method 2 - daemon.json creation - #1023 - #1101

Closed
Gaurav Saini (gauravsaini04) wants to merge 9 commits into
devcontainers:mainfrom
gauravsaini04:docker-in-docker_daemon_creation_#1023
Closed

[docker-in-docker] - method 2 - daemon.json creation - #1023#1101
Gaurav Saini (gauravsaini04) wants to merge 9 commits into
devcontainers:mainfrom
gauravsaini04:docker-in-docker_daemon_creation_#1023

Conversation

@gauravsaini04

@gauravsaini04 Gaurav Saini (gauravsaini04) commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Feature Name

  • Docker-in-Docker

Description

changelog

  • Added a new method to create the /etc/docker/daemon.json file before starting the docker daemon

Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
MICROSOFT_GPG_KEYS_URI="https://packages.microsoft.com/keys/microsoft.asc"
DOCKER_MOBY_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal jammy noble"
DOCKER_LICENSED_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal hirsute impish jammy noble"
IP6_TABLES="${IP6TABLES:-""}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we look into fixing test failures?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I test for ip6tables -L command inside built container, getting the following output:

root@a139636130dc:/# ip6tables -L
ip6tables v1.8.4 (legacy): can't initialize ip6tables table `filter': Table does not exist (do you need to insmod?)
Perhaps ip6tables or your kernel needs to be upgraded.

Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
# Create the daemon.json file with the provided value
cat <<JSON_EOF > /etc/docker/daemon.json
{
"ip6tables": $DEFAULT_IP6_TABLES

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, have you tried using --ip6tables=<value> same like DEFAULT_ADDRESS_POOL ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check for the above mentioned method as a solution here

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have #1068 open, why do we need this PR which attempts to do the same thing?

@gauravsaini04

Copy link
Copy Markdown
Contributor Author

#1068 is an alternate method as a solution for the same issue.

@gauravsaini04
Gaurav Saini (gauravsaini04) deleted the docker-in-docker_daemon_creation_#1023 branch September 10, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants